Skip to content

.kokoro: publish test log to Build Cop Bot - #2775

Merged
tbpg merged 7 commits into
masterfrom
buildcop
Feb 10, 2020
Merged

tbpg merged 7 commits into
masterfrom
buildcop

Conversation

@tbpg

@tbpg tbpg commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

The Build Cop Bot will open/close issues for failing/passing tests.

The Build Cop Bot will open/close issues for failing/passing tests.
@tbpg
tbpg requested a review from a team as a code owner February 5, 2020 16:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
Comment thread .kokoro/tests/run_tests.sh Outdated

# If we're running system tests, send the test log to the Build Cop Bot.
# See https://github.com/googleapis/repo-automation-bots/tree/master/packages/buildcop.
if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"system-tests"* ]]; then

@leahecole leahecole Feb 5, 2020 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this system-tests something that's on the kokoro end or is it searching for it here?

If searching here, it won't find it - we restructured the kokoro config files to be broken down by python version and then into continuous, periodic, presubmit, and lint, unlike before when we had system tests by product

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Switched to continuous. Let me know if you'd prefer periodic.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. They're all going to fail right away - we're slowly but surely resolving all failures within.

@leahecole leahecole assigned kurtisvg and unassigned crwilcox Feb 6, 2020
Comment thread .kokoro/tests/run_tests.sh Outdated
if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"continuous"* ]]; then
# Use the service account with access to the repo-automation-bots project.
gcloud auth activate-service-account --key-file $GOOGLE_APPLICATION_CREDENTIALS
gcloud config set project repo-automation-bots

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use -project flag on the command below instead? Hopefully none of the samples are relying on gcloud to detect projects, but it might be safer to minimize side effects

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Switched.

@tbpg
tbpg merged commit 2b3daa3 into master Feb 10, 2020
@tbpg
tbpg deleted the buildcop branch February 10, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants